Fix ctex to correctly use default Pandoc template #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce by mistake in 23ecb21
but generic pdf_document_format was still defaulting to included template. This requires rmarkdown >=1.18 to default to pandoc's template.
yihui
requested changes
Sep 1, 2020
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
We still need to allow users to customize the template, so shouldn't hard-code it inside ctex_article().
Co-authored-by: Yihui Xie <xie@yihui.name>
Collaborator
Author
|
Changes made. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #322
Currently,
ctex()format is broken because it should use the pandoc default template as stated in 23ecb21 but the changes was not complete.We missed that as it was not properly tested.
Dependency on Rmarkdown needs to be bumped to 1.18, that is the minimum version that use the default pandoc template.
Also small typo in the skeleton as a duplicated documentclass field was introduced in header.