Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioinformatics template: Hard-coded "Manuscript Category" #414

Closed
3 tasks done
stephenturner opened this issue Jun 29, 2021 · 1 comment · Fixed by #415
Closed
3 tasks done

Bioinformatics template: Hard-coded "Manuscript Category" #414

stephenturner opened this issue Jun 29, 2021 · 1 comment · Fixed by #415

Comments

@stephenturner
Copy link
Contributor

rticles version 0.20: The header in the Bioinformatics template has a hard-coded "Manuscript Category" resulting in the header below, regardless of what subject_section is set to in the YAML front matter:

image

Looks like the culprit is around here:

This should probably be replaced with the subject_section variable holding the type of article, as is done further below:


By filing an issue to this repo, I promise that

  • I have fully read the issue guide at https://yihui.name/issue/.
  • I have provided the necessary information about my issue.
    • If I'm asking a question, I have already asked it on Stack Overflow or RStudio Community, waited for at least 24 hours, and included a link to my question there.
    • If I'm filing a bug report, I have included a minimal, self-contained, and reproducible example, and have also included xfun::session_info('rticles'). I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version: remotes::install_github('rstudio/rticles').
    • If I have posted the same issue elsewhere, I have also mentioned it in this issue.
  • I have learned the Github Markdown syntax, and formatted my issue correctly.

I understand that my issue may be closed if I don't fulfill my promises.

cderv added a commit that referenced this issue Jun 29, 2021
* use subject_section in header fixes #414
* separate manuscript_type and subject_section #414 #415
* update NEWS.md to mention manuscript_type and subject_section in template and skeleton
* avoids breaking change by making manuscript_type fallback to subject_section as default if not entered

Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant