Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Revert "add repo name to Snyk project name" #363

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Revert "add repo name to Snyk project name" #363

merged 1 commit into from
Apr 12, 2023

Conversation

Lytol
Copy link
Contributor

@Lytol Lytol commented Apr 12, 2023

This reverts commit f5ea8d8.

Intent

  • Project "groups" are determined by the root repo (which is what we want)
  • Project "names" should be unique for each manifest scan, so there should be a separate named project for "ui" and for "python", which will be grouped under "rstudio/rsconnect-jupyter"

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Other: CI

Approach

N/A

Automated Tests

N/A

Directions for Reviewers

N/A

@Lytol Lytol requested a review from mmarchetti April 12, 2023 21:03
@Lytol Lytol merged commit b38a7e2 into master Apr 12, 2023
@Lytol Lytol deleted the bs-revert-snyk-project-names branch April 12, 2023 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aronatkins aronatkins aronatkins approved these changes

@mmarchetti mmarchetti Awaiting requested review from mmarchetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lytol @aronatkins