Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

add repo name to Snyk project name #361

Merged
merged 1 commit into from
Apr 10, 2023
Merged

add repo name to Snyk project name #361

merged 1 commit into from
Apr 10, 2023

Conversation

mmarchetti
Copy link
Contributor

Intent

The Snyk reports include projects named things like "requirements.txt" and "Pipfile" with no indication of which git repo they originate from.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Update project name in snyk.yml.

Automated Tests

No tests since this is a GHA configuration change.

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@mmarchetti mmarchetti requested a review from Lytol April 10, 2023 17:41
@mmarchetti mmarchetti merged commit bd9f92c into master Apr 10, 2023
@mmarchetti mmarchetti deleted the snyk branch April 10, 2023 18:33
@Lytol
Copy link
Contributor

Lytol commented Apr 10, 2023

I don't think that you want to do it this way. Snyk uses the remote repo URL as the "Project Group" name (which is what you want), and then each type of scan within the repo should have a unique project name. In this instance, you are using the same project name for two different types of scans (the Python requirements and the Node packages)... which will cause unintended issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants