Add support for nested py_capture_output()
calls.
#1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for nested
py_capture_output()
calls. I.e.,py_capture_output({ py_capture_output({ py_run_string("print('hello')") }) })
See the included tests for a fuller example.
The issue with the previous implementation was discovered while investigating a segfault in the Keras testsuite, which would in some situations setup multiple
py_capture_output()
contexts. When that happened, the reference to the originalsys.stdout
would be lost permanently, resulting in no further output, and a cryptic R error message each timeflush_std_buffers()
was invoked from C++ functions or from the R top-level task callback.