Add numeric question type #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
force-pushed
the
question-numeric
branch
from
1003f95 to
3fa052e
Compare
schloerke
reviewed
Jan 4, 2021
schloerke
approved these changes
Jan 4, 2021
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
LGTM. Don't know if we want to change the auto question type behavior. I'm on the fence.
sjgknight
pushed a commit
to sjgknight/learnr
that referenced
this pull request
Aug 10, 2021
gadenbuie
added a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new numeric question type for use when tutorial authors explicilty want users to enter a number.
Requires #450, which lets
answer()accept non-character text inputs (this PR can subsume #450 or I can rebase this PR after #450 is merged).PR task list:
devtools::document()