Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use leaflet.providers package #636

Merged
merged 17 commits into from
Jul 15, 2019
Merged

Use leaflet.providers package #636

merged 17 commits into from
Jul 15, 2019

Conversation

leslie-huang
Copy link
Contributor

@leslie-huang leslie-huang commented Jun 20, 2019 •
edited
Loading

Brief description of the solution

leaflet() %>% addTiles()

PR task list:

  • Update NEWS
  • Compile JavaScript
  • Update documentation with devtools::document()

@schloerke schloerke self-requested a review July 1, 2019 19:13
@leslie-huang

This comment has been minimized.

Sign in to view
@schloerke schloerke requested a review from jcheng5 July 1, 2019 19:46
schloerke
schloerke approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good pending it passes travis

@leslie-huang

This comment has been minimized.

Sign in to view
@schloerke schloerke mentioned this pull request Jul 3, 2019
Closed
@schloerke schloerke changed the title Leafletproviders Use leaflet.providers package Jul 15, 2019
@schloerke schloerke merged commit 18ec981 into rstudio:master Jul 15, 2019
@leslie-huang leslie-huang mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leslie-huang @schloerke @jcheng5