fix relative protocol clientside for tile urls#526
Merged
schloerke merged 5 commits intorstudio:masterfrom Apr 18, 2018
Merged
Conversation
Contributor
Author
Testing Notes.All examples should work within RStudio 1.1.x on linux except for the last one. (fails loading https) devtools::install_github("rstudio/leaflet#526")
#> Using GitHub PAT from envvar GITHUB_PAT
#> Using GitHub PAT from envvar GITHUB_PAT
#> Downloading GitHub repo schloerke/leaflet@urlProtocol
#> from URL https://api.github.com/repos/schloerke/leaflet/zipball/urlProtocol
#> Installing leaflet
#> '/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file \
#> --no-environ --no-save --no-restore --quiet CMD INSTALL \
#> '/private/var/folders/0k/bxg5lhr92sq74mb1d446ql540000gp/T/RtmprL0PE8/devtools987352a32ffb/schloerke-leaflet-1536cca' \
#> --library='/Users/barret/z_R_library' --install-tests
#>
library(leaflet)
# should be a normal world
leaflet() %>% addTiles()
# should contain a map of Ames, IA with red dots / fire icons
leaflet() %>% addTiles() %>% addProviderTiles("OpenFireMap") %>% setView(-93.6, 42.0285, zoom = 15)
# should contain a map of the USA with blue heatmap-like lines/dots over highway areas
leaflet() %>% addTiles() %>% addProviderTiles("SafeCast") %>% setView(-97, 38, zoom = 5)
# should contain a greyscale map of the world. Fails on linux & RStudio combo
leaflet() %>% addProviderTiles("CartoDB.Positron") |
Contributor
|
On my linux machine in RStudio viewer:
|
Member
|
@tim-salabim The crash for 3 is a little scary. 4 is expected. The situation is not ideal, but I'm guessing this is the best we'll be able to do. For what it's worth, all of these should work perfectly in RStudio 1.2 on all platforms. |
Contributor
|
Is it worth testing with a daily RStudio build? If so, I will do so tonite |
Contributor
|
With RStudio version 1.2.567 all 4 examples work as expected, no crashing, no blank viewer panes |
schloerke
added a commit
to schloerke/leaflet
that referenced
this pull request
Apr 23, 2018
* master: v2.0.0 release tweaks (rstudio#531) v2.0.0 init submission to cran (rstudio#530) fix relative protocol clientside for tile urls (rstudio#526) Add comment about webshot being required for reprex::reprex to work (rstudio#529)
schloerke
added a commit
to schloerke/leaflet
that referenced
this pull request
Apr 24, 2018
* master: v2.0.0 release tweaks (rstudio#531) v2.0.0 init submission to cran (rstudio#530) fix relative protocol clientside for tile urls (rstudio#526) Add comment about webshot being required for reprex::reprex to work (rstudio#529)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Even with the fix, this error still exists on linux in RStudio with
In the inspector...