Skip to content

v2.0.0 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 136 commits into from
Mar 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
136 commits
Select commit Hold shift + click to select a range
a648357
add simple crosstalk example
timelyportfolio Dec 30, 2016
f1e63f5
add basic crosstalk + shiny example
timelyportfolio Dec 30, 2016
31b8d05
Merge branch 'master' of https://github.com/rstudio/leaflet
timelyportfolio Dec 30, 2016
9261eca
hack to make leaflet only render once
timelyportfolio Dec 30, 2016
d1294a3
change to master for leaflet and crosstalk
timelyportfolio Dec 30, 2016
e9267e4
uglier by the commit; fix error with ui introduced by leaflet once re…
timelyportfolio Dec 30, 2016
f9ac904
Merge branch 'master' of https://github.com/rstudio/leaflet
timelyportfolio Jan 9, 2017
b4bc9d9
add an example using Shiny to get polygon from Leaflet.Draw and then …
timelyportfolio Jan 9, 2017
c5e27b4
add example with Shiny gadget for Leaflet.Draw; cc @tim-salabim
timelyportfolio Jan 10, 2017
4c75faf
add more complex Leaflet.Draw Shiny gadget; ref https://github.com/ti…
timelyportfolio Jan 10, 2017
351f0ef
fix small bug in second draw gadget example
timelyportfolio Jan 11, 2017
1880efb
also show how to plot points not within using lawn/turf
timelyportfolio Jan 11, 2017
e3010c2
quick little poc to combine listviewer::jsonedit with mapview to have…
timelyportfolio Jan 13, 2017
1deebd6
add Leaflet.Draw deleted shiny example
timelyportfolio Jan 17, 2017
ce3c1d7
test out leaflet with Split.js
timelyportfolio Jan 18, 2017
62907df
add resize on drag
timelyportfolio Jan 19, 2017
d1c3ef7
test with split.js and svglite responsive svg
timelyportfolio Jan 19, 2017
1695722
add support for simple features MULTIPOLYGON. lines to follow
tim-salabim Jan 22, 2017
9f3e437
Fix #390: validateCoords warns on valid polygon data
jcheng5 Feb 28, 2017
678bae1
ensure type safety of .indexOf(stamp); fixes #395
cpsievert Mar 1, 2017
2d42d10
Merge branch 'master' of https://github.com/rstudio/leaflet
timelyportfolio Mar 10, 2017
c087ffd
copy/paste leaflet.js 1.0.3
timelyportfolio Mar 10, 2017
c1c030e
keep log of all errors found
timelyportfolio Mar 10, 2017
00eff02
change to leaflet version 1.0.3 in yaml
timelyportfolio Mar 11, 2017
4b841f0
fix (partially) marker.png not found error
timelyportfolio Mar 11, 2017
6d0e4e1
upgrade leaflet-measure to 2.1.5
timelyportfolio Mar 11, 2017
7279a94
add note in errors about leaflet-measure broken status
timelyportfolio Mar 11, 2017
f6a25e9
change leaflet-measure version in htmlDependency to 2.1.5 and remove …
timelyportfolio Mar 11, 2017
6899951
discovered remove controls do not work so log in errors
timelyportfolio Mar 11, 2017
c6762e3
temp fix for leaflet-measure but need to rewrite some legacy controls…
timelyportfolio Mar 11, 2017
55334c1
fix leaflet-measure and layersControl to use addControl and removeCon…
timelyportfolio Mar 13, 2017
a4875a3
start to remove leaflet-label since now L.tooltip
timelyportfolio Mar 13, 2017
8f78977
start discussing changes in NEWS to keep track
timelyportfolio Mar 13, 2017
03d6b38
update leaflet-markercluster to 1.0.4 and update its plugins
timelyportfolio Mar 14, 2017
f448c72
fix markercluster permanent/noHide tooltip for L.tooltip
timelyportfolio Mar 14, 2017
ea92252
change default label offset to same as default L.tooltip offset 0,0
timelyportfolio Mar 14, 2017
05dea44
update leaflet-omnivore to 0.3.4
timelyportfolio Mar 14, 2017
c1405d5
remove old bower from leaflet-providers
timelyportfolio Mar 14, 2017
aba117c
update to proj4leaflet 1.0.1 and test with http://rpubs.com/bhaskarvk…
timelyportfolio Mar 15, 2017
96667e3
step toward fixing broken addRasterImage; displays now but still not …
timelyportfolio Mar 15, 2017
83bee11
fix no. 2 on addRasterImage now displaying correctly but not working …
timelyportfolio Mar 16, 2017
298889e
Add support for dragend notification
imprompt Mar 22, 2017
a807435
Raster: Fix issue where rasters appear behind tiles by default
jcheng5 Aug 18, 2017
bb4e33d
Fix issue with rasters disappearing
jcheng5 Aug 18, 2017
3e65a74
Merge branch 'master' into v1.0
jcheng5 Aug 21, 2017
b719a0f
Upgrade to Leaflet 1.2.0
jcheng5 Aug 21, 2017
d19bd52
Rebuild docs
jcheng5 Aug 21, 2017
8216a70
begin update of markercluster to v0.1.1
timelyportfolio Aug 30, 2017
cced766
update leaflet-measure to 2.1.7
timelyportfolio Aug 30, 2017
167d879
update leaflet-omnivore to 0.3.4
timelyportfolio Aug 30, 2017
c60a979
update proj4leaflet to 1.0.2
timelyportfolio Aug 31, 2017
3af495a
update leaflet-minimap to 3.5.0
timelyportfolio Aug 31, 2017
fe4a794
update Leaflet.EasyButton to 2.2.2
timelyportfolio Aug 31, 2017
570aff5
update leaflet.graticule
timelyportfolio Aug 31, 2017
7668428
delete local version of normalize-sf
tim-salabim Sep 9, 2017
1ac6130
merge upstream
tim-salabim Sep 9, 2017
0102062
add method argument to addRasterImage, fixes #219 and #461.
tim-salabim Sep 9, 2017
480e15a
add argument elementId to leaflet. fixes #411
tim-salabim Sep 9, 2017
ada5aa6
attempt to resolve cluster layer support and freezable conflict
timelyportfolio Sep 28, 2017
d40024c
change order of load for freezable and layersupport to get freeze wor…
timelyportfolio Sep 29, 2017
57d6349
#453 + #458 + Fix for locationfilter + latest plugins
Nov 6, 2017
1f0ee97
Merge remote-tracking branch 'upstream/pr/462' into upgrade/leaflet-v1.x
Nov 6, 2017
bdfdee2
Merge remote-tracking branch 'upstream/pr/405' into upgrade/leaflet-v1.x
Nov 6, 2017
73aaa4c
Merge remote-tracking branch 'upstream/pr/396' into upgrade/leaflet-v1.x
Nov 6, 2017
42f17e2
Merge remote-tracking branch 'upstream/pr/393' into upgrade/leaflet-v1.x
Nov 6, 2017
fa5e14d
grunt build after merging PRs
Nov 6, 2017
307326b
Minor fixes/documentation, and example updates
Nov 6, 2017
5104525
Fixed All issues with Proj4Leaflet support (I think!)
Nov 10, 2017
e35b661
Latest Providers
Nov 13, 2017
6a3d207
Deprecated L.Proj.CRS.TMS
Nov 13, 2017
5fb5001
Fixed Arguments, but retained backward compatibility. Fixed links to …
Nov 13, 2017
5baeada
Fixes #456
Nov 13, 2017
279c44b
remove examples left from testing/experimentation
timelyportfolio Nov 21, 2017
fb7bc81
Merge pull request #17 from timelyportfolio/v1.x
bhaskarvk Nov 21, 2017
3f80139
directly use utils::globalVariables
schloerke Feb 9, 2018
3e2f234
safeguard against layers check
schloerke Feb 9, 2018
3c5a9fd
add changeView to isolate map changes
schloerke Feb 9, 2018
42eedf9
cast 'stamp' to a character at creation. not when creating 'idx'
schloerke Feb 9, 2018
1bbc1e4
add new line to avoid read warnings
schloerke Feb 12, 2018
a41266f
ignore revdep files
schloerke Feb 12, 2018
ea51e02
set up lintr for future cleaning
schloerke Feb 12, 2018
ba1e66e
current revdep execution. good outloook
schloerke Feb 12, 2018
59cd990
update version. add Barret as ctb. remove Date field
schloerke Feb 12, 2018
69a5211
news under version 1.2.0
schloerke Feb 12, 2018
6961167
added data arg to addXXX methods, including addLegend
schloerke Feb 12, 2018
f273edd
Merge pull request #1 from schloerke/barret/addLegend_data
schloerke Feb 12, 2018
74e75d4
use template for addLegend data param
schloerke Feb 12, 2018
7035878
correct leaflet.js version
schloerke Feb 13, 2018
9accc7e
use an 'auto' method for raster. as.factor projected factors
schloerke Feb 13, 2018
0d36b8a
updated news with pr nums and more items
schloerke Feb 13, 2018
5d1bc7d
Github Templates (#2)
schloerke Feb 14, 2018
7560337
version 2.0.0
schloerke Feb 14, 2018
10b90b2
don't test shinyApp in utils.R example
schloerke Feb 15, 2018
e2d8197
force palette fn to avoid scope issues
schloerke Feb 15, 2018
fad2665
lintr (#5)
schloerke Feb 16, 2018
8a8f2e8
use dev version of webshot to take pics of shiny apps
schloerke Feb 22, 2018
b4b9bee
display graticule example
schloerke Feb 22, 2018
16c6ba8
adjust shiny examples
schloerke Feb 22, 2018
e48491e
removed remotes from description
schloerke Feb 23, 2018
9859da6
change map example to be created before shiny app
schloerke Mar 2, 2018
c96834f
add a raster script to use for later
schloerke Mar 2, 2018
da01f65
add viztest comparison
schloerke Mar 2, 2018
314616f
update leaflet to 1.3.1
schloerke Mar 14, 2018
57cbf37
do not fix default icon as new css now includes path
schloerke Mar 14, 2018
cd30b2b
compile
schloerke Mar 14, 2018
3ba9ffe
add helper scripts to build or watch
schloerke Mar 14, 2018
f6a943c
bump leaflet version in the htmlwidgets yaml
schloerke Mar 14, 2018
2a60751
fix for bad iconSize being passed into the js hand-off
schloerke Mar 14, 2018
c54878f
update icon example to fix missing images
schloerke Mar 15, 2018
14f7ae6
have examples print the leaflet objects created
schloerke Mar 15, 2018
647d3aa
ignore _ignore folder
schloerke Mar 16, 2018
cc79bc3
fix missing icons in self contained knitr files
schloerke Mar 16, 2018
72b6f56
document
schloerke Mar 16, 2018
89a23ab
add additional viztest line
schloerke Mar 16, 2018
bb4922b
add small news items
schloerke Mar 16, 2018
2d92a14
put back missing 1px image
schloerke Mar 16, 2018
770eb67
Remove deprecated br clear
nikolai-b Mar 2, 2018
93def07
bump version to 2.0.0
schloerke Mar 21, 2018
76a9ce0
add notification where bug was fixed about icon anchor position
schloerke Mar 26, 2018
cd567ac
update viztest script to install viztest
schloerke Mar 26, 2018
1eaa297
fix html escape error in easybutton example
schloerke Mar 27, 2018
586b8c4
add viztest notes for qa
schloerke Mar 27, 2018
5aa8ef6
Merge branch 'legend_zoom' of https://github.com/nikolai-b/leaflet in…
schloerke Mar 27, 2018
a7272b6
have the margin-right be align with the labelPadding and remove the a…
schloerke Mar 27, 2018
3bf67be
add `right` varaible for cut inside colorBin and colorQuantile (rstud…
schloerke Mar 27, 2018
77659ed
pass devtools::check()
schloerke Mar 27, 2018
e855a51
added grunt-cli to npm devdependencies and removed unnecessary npm info
schloerke Mar 28, 2018
9576363
fix eazybuttonbar example by making the text raw html
schloerke Mar 28, 2018
c9ce195
remove all library(leaflet) in .Rd
schloerke Mar 28, 2018
9ac126d
use docs folder for docs instead of gh-pages (#8)
schloerke Mar 28, 2018
3074556
documented docs/
schloerke Mar 28, 2018
5d7649a
added a crosstalk script for testing
schloerke Mar 28, 2018
5eb8181
add cran comments and update revdep
schloerke Mar 29, 2018
ae2ffde
update leaflet.js links to point to v1.3.1
schloerke Mar 29, 2018
67cefa4
draft email and add notes on updated packages for leaflet
schloerke Mar 29, 2018
72529ab
draft email
schloerke Mar 29, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
18 changes: 18 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,21 @@
^package\.json$
^node_modules$
^data-raw$
^npm-shrinkwrap\.json$
^\.Rprofile\.local$
^inst/htmlwidgets/lib/.*/.*\.map$
^inst/htmlwidgets/plugins/.*/.*\.map$
^inst/htmlwidgets/lib/jquery/jquery.js$
^inst/htmlwidgets/lib/leaflet/leaflet-src.js$
^inst/htmlwidgets/plugins/Leaflet.markercluster/leaflet.markercluster.freezable-src.js$
^inst/htmlwidgets/plugins/Leaflet.markercluster/leaflet.markercluster.layersupport-src.js$
^inst/htmlwidgets/plugins/Leaflet.markercluster/leaflet.markercluster-src.js$
^inst/htmlwidgets/lib/leaflet-measure/leaflet-measure.js$
^inst/htmlwidgets/plugins/Proj4Leaflet/proj4.js$
^revdep/
^\.lintr$
^\.github/
^man-roxygen/
^viztest-.*
^scripts
^cran-comments\.md$
38 changes: 38 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
We welcome contributions to the **leaflet** package!

To submit a contribution:

1. [Fork](https://github.com/rstudio/leaflet/fork) the repository and make your changes.

2. Ensure that you have signed the [individual](https://rstudioblog.files.wordpress.com/2017/05/rstudio_individual_contributor_agreement.pdf) or [corporate](https://rstudioblog.files.wordpress.com/2017/05/rstudio_corporate_contributor_agreement.pdf) contributor agreement as appropriate. You can send the signed copy to jj@rstudio.com.

3. Submit a [pull request](https://help.github.com/articles/using-pull-requests).

We generally do not merge pull requests that update included web libraries (such as Bootstrap or jQuery) because it is difficult for us to verify that the update is done correctly; we prefer to update these libraries ourselves.


## How to make changes

Before you submit a pull request, please do the following:

* Add an entry to NEWS concisely describing what you changed.

* If appropriate, add unit tests in the tests/ directory.

* Run Build->Check Package in the RStudio IDE, or `devtools::check()`, to make sure your change did not add any messages, warnings, or errors.

Doing these things will make it easier for the leaflet development team to evaluate your pull request. Even so, we may still decide to modify your code or even not merge it at all. Factors that may prevent us from merging the pull request include:

* breaking backward compatibility
* adding a feature that we do not consider relevant for leaflet
* is hard to understand
* is hard to maintain in the future
* is computationally expensive
* is not intuitive for people to use

We will try to be responsive and provide feedback in case we decide not to merge your pull request.


## Filing issues

If you find a bug in leaflet, you can also [file an issue](https://github.com/rstudio/leaflet/issues/new). Please provide as much relevant information as you can, and include a minimal reproducible example if possible.
13 changes: 13 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Please briefly describe your problem and what output you expect. If you have a question, please try using stackoverflow <http://stackoverflow.com> first.

Please include a minimal reprex. The goal of a reprex is to make it as easy as possible for me to recreate your problem so that I can fix it. If you've never heard of a reprex before, start by reading <https://github.com/jennybc/reprex#what-is-a-reprex>, and follow the advice further down the page. Do NOT include session info unless it's explicitly asked for, or you've used `reprex::reprex(..., si = TRUE)` to hide it away.

Delete these instructions once you have read them.

---

Brief description of the problem

```r
# insert reprex here
```
39 changes: 39 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
## Pull Request

Before you submit a pull request, please do the following:

* Add an entry to NEWS concisely describing what you changed.

* If appropriate, add unit tests in the tests/testthat directory.

* Run Build->Check Package in the RStudio IDE, or `devtools::check()`, to make sure your change did not add any messages, warnings, or errors.

Doing these things will make it easier for the leaflet development team to evaluate your pull request. Even so, we may still decide to modify your code or even not merge it at all. Factors that may prevent us from merging the pull request include:

* breaking backward compatibility
* adding a feature that we do not consider relevant for leaflet
* is hard to understand
* is hard to maintain in the future
* is computationally expensive
* is not intuitive for people to use

We will try to be responsive and provide feedback in case we decide not to merge your pull request.

## Minimal reproducible example

Finally, please include a minimal reprex. The goal of a reprex is to make it as easy as possible for me to recreate your problem so that I can fix it. If you've never heard of a reprex before, start by reading <https://github.com/jennybc/reprex#what-is-a-reprex>, and follow the advice further down the page. Do NOT include session info unless it's explicitly asked for, or you've used `reprex::reprex(..., si = TRUE)` to hide it away.

Delete these instructions once you have read them.

---

Brief description of the solution

```r
# insert reprex here
```

PR task list:
- [ ] Update NEWS
- [ ] Add tests (if appropriate)
- [ ] Update documentation with `devtools::document()`
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ inst/htmlwidgets/sources
inst/examples/rsconnect
inst/examples/*.html
R/tags
revdep/checks.noindex
revdep/library.noindex
revdep/data.sqlite
viztest-*
8 changes: 8 additions & 0 deletions .lintr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
linters: with_defaults(
camel_case_linter = NULL,
line_length_linter = NULL, # line_length_linter(100),
commented_code_linter = NULL,
object_usage_linter = NULL,
NULL
)
exclusions: list()
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ notifications:
email:
on_success: change
on_failure: change

r_github_packages:
- jimhester/lintr
after_success:
- Rscript -e 'lintr::lint_package()'
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Package: leaflet
Type: Package
Title: Create Interactive Web Maps with the JavaScript 'Leaflet' Library
Version: 1.1.0.9000
Date: 2017-02-17
Version: 2.0.0
Authors@R: c(
person("Joe", "Cheng", email = "joe@rstudio.com", role = c("aut", "cre")),
person("Bhaskar", "Karambelkar", role = c("aut")),
person("Yihui", "Xie", role = c("aut")),
person("Hadley", "Wickham", role = c("ctb")),
person("Kenton", "Russell", role = c("ctb")),
person("Kent", "Johnson", role=c("ctb")),
person("Kent", "Johnson", role = c("ctb")),
person("Barret", "Schloerke", role = c("ctb")),
person("jQuery Foundation and contributors", role = c("ctb", "cph"), comment = "jQuery library"),
person("Vladimir", "Agafonkin", role = c("ctb", "cph"), comment = "Leaflet library"),
person("CloudMade", role = c("cph"), comment = "Leaflet library"),
Expand Down
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ export(expandLimits)
export(expandLimitsBbox)
export(filterNULL)
export(fitBounds)
export(flyTo)
export(flyToBounds)
export(getMapData)
export(groupOptions)
export(hideGroup)
Expand Down
41 changes: 39 additions & 2 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,6 +1,32 @@
leaflet 1.1.1
leaflet 2.0.0
--------------------------------------------------------------------------------

* Update to latest leaflet.js v1.3.1 (#453, 314616f) Please see http://leafletjs.com/reference-1.3.0.html for the latest documentation

* All plugins updated to versions compatible with leaflet > 1.0 (#458)

_ jQuery, https://github.com/jquery/jquery
_ Leaflet (JavaScript library), https://github.com/Leaflet/Leaflet
_ Leaflet Providers, https://github.com/leaflet-extras/leaflet-providers
_ leaflet-measure, https://github.com/ljagis/leaflet-measure
_ Leaflet.label, https://github.com/Leaflet/Leaflet.label
_ Leaflet.Terminator, https://github.com/joergdietrich/Leaflet.Terminator
_ Leaflet.SimpleGraticule, https://github.com/ablakey/Leaflet.SimpleGraticule
_ Leaflet.MagnifyingGlass, https://github.com/bbecquet/Leaflet.MagnifyingGlass
_ Leaflet.MiniMap, https://github.com/Norkart/Leaflet-MiniMap
_ Leaflet.awesome-markers, https://github.com/lvoogdt/Leaflet.awesome-markers
_ Leaflet.EasyButton, https://github.com/CliffCloud/Leaflet.EasyButton/
_ Proj4Leaflet, https://github.com/kartena/Proj4Leaflet
_ leaflet-locationfilter, https://github.com/kajic/leaflet-locationfilter
_ leaflet-omnivore, https://github.com/mapbox/leaflet-omnivore
_ topojson, https://github.com/topojson/topojson

* Fix bug where icons where anchored to the top-center, not center-center (2a60751)

* Fix bug where markers would not appear in self contained knitr files (cc79bc3)

* leaflet-label plugin now L.tooltip in leaflet.js. labelOptions() now translates old options clickable to interactive and noHide to permanent.

* Fix a bug where the default `addTiles()` would not work with .html files
served directly from the filesystem.

Expand All @@ -15,6 +41,18 @@ leaflet 1.1.1

* Fix incorrect opacity on NA entry in legend. (PR #425)

* Added support for drag events (#405)

* Ensure type safety of .indexOf(stamp) (#396)

* `validateCoords()` warns on invalid polygon data (#393)

* Added `method` argument to `addRasterImage()` to enable nearest neighbor interpolation when projecting categorical rasters (#462)

* Added an `'auto'` method for `addRasterImage()`. Projected factor results are coerced into factors. (9accc7e)

* Added `data` parameter to remaining `addXXX()` methods, including addLegend. (f273edd, #491, #485)

leaflet 1.1.0
--------------------------------------------------------------------------------

Expand Down Expand Up @@ -103,4 +141,3 @@ leaflet 1.0.0
--------------------------------------------------------------------------------

* Initial release

Loading