`ordered = TRUE` makes more sense for `colorFactor`

[bogaotory]

leaflet/R/colors.R

Line 211 in 0016c07

colorFactor <- function(palette, domain, levels = NULL, ordered = FALSE,

I was a bit confused when running the last code block (under the title "Circle Markers") of the example given at https://rstudio.github.io/leaflet/markers.html

When the code is written as pal <- colorFactor(c("navy", "red"), domain = c("ship", "pirate")), then it is highly likely that the user's intention is to have navy for ship, and red for pirate.
Therefore it makes more sense that colorFactor should assume that the domain vector is already ordered (ordered = TRUE) unless stated otherwise.

[jcheng5]

@hadley Can you think of any possible reason ordered = FALSE would've made sense? The fact that I can't think of a single benefit makes me think there must be something I'm missing.

[hadley]

I have literally no recollection of this code 😞