Skip to content

Conversation

@gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Jun 11, 2025

This PR adds a resize handle into the sidebar element of layout_sidebar() to make all desktop (or wide-screen) sidebars resizable.

This is a Typescript and Sass-only change and does not require any R or Python updates.

Also, the initial implementation was written by Claude Sonnet 4 but I've reviewed all changes and made a few changes for code style and consistency and to improve the accessibility of the component.

Kapture.2025-06-11.at.13.39.26.mp4

@gadenbuie gadenbuie requested a review from cpsievert June 11, 2025 17:41
@gadenbuie
Copy link
Member Author

gadenbuie commented Jun 11, 2025

On second thought, non-collapsible desktop sidebars should be resizable, too. That starts to beg the question of adding an option, like resizable, but I think it's complicated enough that we should just have desktop sidebars always be resizable.

@gadenbuie gadenbuie changed the title feat(sidebar): Collapsible sidebars are now resizable feat(sidebar): Desktop sidebars are now resizable Jun 11, 2025
gadenbuie and others added 3 commits June 12, 2025 09:02
Avoids scrolling the resize handle out of view when the sidebar content overflows and is scrolled
@cpsievert
Copy link
Collaborator

Nice! I'd like to have one more closer look before merging, but consider this basically approved. Let me know when you're ready to merge, and I'll have one more closer look

@gadenbuie
Copy link
Member Author

Let me know when you're ready to merge, and I'll have one more closer look

I think you can go ahead with that look, the comments so far will be easy to address and don't involve any large changes

@cpsievert
Copy link
Collaborator

Great work, excited for this to land! 👏

@gadenbuie
Copy link
Member Author

Thanks for the comments and review @cpsievert! Everything was easy to resolve, so I'm going to merge this.

Note: We have some flip-flopping happening with snapshots on Mac R 4.5.1 that I can't fully explain (hoping the issue will go away eventually, or we can fix as needed before next release).

@gadenbuie gadenbuie merged commit 9562108 into main Jul 3, 2025
12 of 13 checks passed
@gadenbuie gadenbuie deleted the feat/sidebar-resize branch July 3, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants