Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit risk classification with deep learning #23

Open
dsaada opened this issue Dec 17, 2018 · 10 comments
Open

Credit risk classification with deep learning #23

dsaada opened this issue Dec 17, 2018 · 10 comments

Comments

@dsaada
Copy link

dsaada commented Dec 17, 2018

Hi all,

I would like to puplish this article on R blog TensorFlow,
the link of my Github:

https://dsaada.github.io/CreditRiskTensorFlow/

Thanks,
david.saada@hotmail.fr

David

@jjallaire
Copy link
Member

We probably need a bit more narrative to publish this. I also can't opine on the approach/results but @skeydan likely can. @skeydan What do you think needs to be added here to make it publish worthy?

@dsaada
Copy link
Author

dsaada commented Dec 18, 2018 via email

@skeydan
Copy link
Contributor

skeydan commented Dec 18, 2018

Hi,

thanks for your interest to publish on the blog.
Like @jjallaire already said, I would expect more narrative throughout. In particular, I think the following questions should be addressed:

  1. (Not a question). This is not a convolutional neural network (like you say in the abstract).

  2. What is the motivation of the post? In principle, when showing an example of a straightforward, default-ish feedforward network (no hyperparameter tuning, etc.) I see 2 possible motivations:

  • compare performance to "classical" methods for the task at hand. For example, random forests, logistic regression... Then the outcome would be "deep learning does it better", or "does it as well as", etc.

  • Use the example to explain to beginners how to use Keras. If that's the motivation, you'd want to explain how you define a model, compile it, train it, etc. Probably this approach would make most sense here.

  1. Here I have a list of unordered questions / remarks, whose importance (resp., the way to address them) would vary depending on what's the underlying motivation (see above).
  • How did you arrive at the dropout rate chosen?
  • Why so few units for the dense layers? (these are uncommon numbers)
  • There is no further improvement after epoch 2, why?
  • You display lots of metrics/indicators, - what do you conclude from them?
  • How about the class imbalance, do you see it as a problem?
  1. More narrative overall - what kind of dataset is it, where do you download it, why do you preprocess it the way you do?

To sum up: Quoting your last sentence

Conclusion: this example show how to use Keras API for binary classification.

this brings me back to the question of motivation. Who do you address here? If you address people who want to learn "how to use Keras API for binary classification.", they will need a lot more information.
Such as: What is an activation, what is a loss, etc.
If you turn it into a "getting started" - type post, you don't have to worry about things like class imbalance etc. ...It all comes down to whom you're addressing.

@dsaada
Copy link
Author

dsaada commented Dec 18, 2018 via email

@skeydan
Copy link
Contributor

skeydan commented Dec 18, 2018

Or i do the modification and i show you?

Yeah that's what I meant :-)

@dsaada
Copy link
Author

dsaada commented Dec 18, 2018 via email

@dsaada
Copy link
Author

dsaada commented Dec 19, 2018 via email

@skeydan
Copy link
Contributor

skeydan commented Dec 20, 2018

Hi,

first of all, thanks again for your interest in publishing on the blog. We've discussed this and we feel that although the exposition is interesting, the text does not fit in completely with other contributed posts.

Asking for contributions, what we mostly have in mind is applications by practitioners, in their respective work areas. These would normally entail quite a bit of domain specific context and domain-specific "tips and tricks" to get deep learning to work well.
Contributions could also be more technology-related, like exploring lesser used features, or tuning-oriented, striving for optimal performance on a dataset.
When I said this would probably rather make for an introduction for beginners, what I had in mind was an article intended as an introduction to basic feedforward networks, which would have to be quite a bit more detailed, and specifically tailored to presenting core ideas of deep learning (resp. DL frameworks).

I'm sorry I didn't reply like that in the beginning and caused you to spend more time. On the other hand, you could certainly publish it yourself, e.g., on github pages. Like that, it won't have been wasted time!

Best,
Sigrid

@dsaada
Copy link
Author

dsaada commented Dec 20, 2018 via email

@skeydan
Copy link
Contributor

skeydan commented Dec 20, 2018

Sorry, what I meant was we decided otherwise (for the above reasons).
But you can always publish it yourself - like that, it's publicly visible too.
And again, sorry for not having responded that way from the outset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants