Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setting for automatic GitHub update check #255

Closed
passibe15 opened this issue Jan 31, 2024 · 3 comments
Closed

Adding setting for automatic GitHub update check #255

passibe15 opened this issue Jan 31, 2024 · 3 comments

Comments

@passibe15
Copy link

passibe15 commented Jan 31, 2024

Following #251, the newest 2.3.2 pre-release seems to have fixed the issues relating to no internet connectivity for me as well (smoothly running for about 18 hours now).
However, from my firewall logs I can see that the ESP device is trying to connect to GitHub (for me its IP addresses 140.82.121.3 and 140.82.121.4) every four hours.

So as a feature request:
Would it be possible to simply add a checkbox e.g. on the firmware page saying "Automatically check for updates" (or something along those lines) to disable this?
With the checkbox enabled the timer would not run and e.g. requests to github would only be made when clicking on "GITHUB UPDATE", while then displaying an error message/retry button if GitHub is not reachable.

Thanks!

@rstrouse
Copy link
Owner

Yes that feature is already in the works. I did set the timing for 4 hours so that is correct but the final will only check once a day.

@rstrouse
Copy link
Owner

The latest pre-release v2.3.2 has this feature.

@passibe15
Copy link
Author

Wow, that was quick. I just installed it and everything seems to work so far.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants