Skip to content

fix type inconsistency #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix type inconsistency #40

wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 15, 2014

This commit fixed type consistency between value of checkbox and the data `row-id' of the row.

If the identifier is { id: "12"} , checkbox value will be the exact string "12" while the data `row-id' ( converted from the type) will be integer 12. When rowSelect is true and user performs rowSelect, the selectedrows will be [12], however, if he/she uses selectbox, the selectedrows will be ["12"]. This type consistency will mess up all logic of deciding selected rows.

How can one trigger this bug?

set rowSelect and multiSelect be true.
and let data be [{id: "1"}, {id: "2"}].

rowSelect row 1 then unselect using checkbox, then rowSelect row 2 and one can see both row 1 and row 2 are selected.

This commit fixed type consistency between value of checkbox and the data `row-id' of the row.
@rstaib rstaib added the bug label Oct 20, 2014
@rstaib rstaib self-assigned this Oct 20, 2014
rstaib added a commit that referenced this pull request Oct 21, 2014
rstaib added a commit that referenced this pull request Oct 21, 2014
@rstaib
Copy link
Owner

rstaib commented Oct 21, 2014

Thank you for the hint. I fixed the bug shortly. Actually, the bug wasn't here but there. Anyway your analysis work and the resulting information were very helpful. Maybe your next commit goes into the main repository ;-)

@rstaib rstaib closed this Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants