Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed type consistency between value of checkbox and the data `row-id' of the row.
If the identifier is { id: "12"} , checkbox value will be the exact string "12" while the data `row-id' ( converted from the type) will be integer 12. When rowSelect is true and user performs rowSelect, the selectedrows will be [12], however, if he/she uses selectbox, the selectedrows will be ["12"]. This type consistency will mess up all logic of deciding selected rows.
How can one trigger this bug?
set rowSelect and multiSelect be true.
and let data be [{id: "1"}, {id: "2"}].
rowSelect row 1 then unselect using checkbox, then rowSelect row 2 and one can see both row 1 and row 2 are selected.