Skip to content

Conversation

@SyMind
Copy link
Collaborator

@SyMind SyMind commented Sep 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 25, 2025 11:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the RawBufferSource struct to remove dependency on the ouroboros crate for self-referencing patterns. The refactoring changes how the struct manages its cached string representation of buffer data.

Key changes:

  • Removes ouroboros dependency and self-referencing patterns from RawBufferSource
  • Replaces borrowed string cache with owned string storage using Option<String>
  • Updates all trait implementations to work with direct field access instead of ouroboros methods

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/raw_source.rs Refactors RawBufferSource to eliminate self-referencing patterns and simplifies struct definition
Cargo.toml Removes unused ouroboros dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 25, 2025

CodSpeed Performance Report

Merging #173 will not alter performance

Comparing SyMind:refactor-RawBufferSource (9ba550e) with main (abb8ead)

Summary

✅ 7 untouched

@SyMind SyMind merged commit 1004eb2 into rstackjs:main Sep 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants