Skip to content

Feature/empty values are nil #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
optional (0.0.5)
optional (0.0.6)

GEM
remote: https://rubygems.org/
Expand Down
3 changes: 1 addition & 2 deletions lib/optional/option.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Option
include Option::Enumerable

def self.[] value
value.nil? ? None : Some[value]
Empty[value] ? None : Some[value]
end

def match(&block)
Expand All @@ -24,5 +24,4 @@ def from_array(values)
def from_value(value)
value.nil? ? None : Some[value]
end

end
1 change: 1 addition & 0 deletions lib/optional/option/all.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
require_relative 'empty'
require_relative 'enumerable'
require_relative 'errors'
require_relative 'match'
7 changes: 7 additions & 0 deletions lib/optional/option/empty.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module Option
class Empty
def self.[] value
value.respond_to?(:empty?) ? value.empty? : !value
end
end
end
12 changes: 12 additions & 0 deletions spec/lib/optional/option_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,16 @@
it 'can create a none from a passed value' do
Option[nil].should be_none
end

it 'treats empty strings as none' do
Option[""].should be_none
end

it 'treats empty collections as none' do
Option[[]].should be_none
end

it 'treats empty hashes as none' do
Option[{}].should be_none
end
end