Skip to content

Docs cleanup #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2015
Merged

Docs cleanup #77

merged 2 commits into from
Oct 25, 2015

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Oct 25, 2015

I found more to do here, sorry. /cc @myronmarston

@myronmarston
Copy link
Member

Github is telling me:

Sorry, we could not display the entire diff because too many files (1,122) changed.

...so I didn't view the whole thing, but what I saw looked fine. I trust you, so merge away.

@JonRowe
Copy link
Member Author

JonRowe commented Oct 25, 2015

It's basically all the nested html files had ../../ paths so my ag | sed failed first time around and I didn't notice until I checked the other files.

JonRowe added a commit that referenced this pull request Oct 25, 2015
@JonRowe JonRowe merged commit e29ac45 into source Oct 25, 2015
@JonRowe JonRowe deleted the docs_cleanup branch October 25, 2015 23:56
@myronmarston
Copy link
Member

Something in either this or #76 broke things. When you click on "Class List" or "Method List" it used to provide a navigable drop-down and also allow you to type in the search box to filter. For 3.2 and before that seems to work:

http://rspec.info/documentation/3.2/rspec-expectations/

But for 3.3, the "Class List" and "Method List" links just link to a page that display the list (presumably, YARD's fallback when the js doesn't work) and the search box does not work:

http://rspec.info/documentation/3.3/rspec-expectations/

Note that the 3.3 docs for rspec-core and rspec-rails seem to work here. It's just rspec-mocks and rspec-expectations that have this problem.

Can you take a look, @JonRowe? Would be nice to have this fixed when it comes time to generate the 3.4 docs this week.

@JonRowe
Copy link
Member Author

JonRowe commented Nov 10, 2015

It's the same problem as the css, so the solution for that could be modified to do this, I'm not sure I'll have time to get to it this week but I'll try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants