Skip to content

Bradley is back from time off so let’s move him back to current team. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2015

Conversation

myronmarston
Copy link
Member

I can't get this to render right, though:

screen shot 2015-10-02 at 6 43 19 am

Anyone with more CSS know-how than I have want to take a stab at fixing it?

/cc @rspec/rspec

@soulcutter
Copy link
Member

That should fix the padding.

soulcutter added a commit that referenced this pull request Oct 3, 2015
Bradley is back from time off so let’s move him back to current team.
@soulcutter soulcutter merged commit 9f28cb4 into source Oct 3, 2015
@soulcutter soulcutter deleted the move-bradley-pic branch October 3, 2015 19:41
@soulcutter
Copy link
Member

I merged, but I cannot deploy the changes.

@myronmarston
Copy link
Member Author

Thanks! I can't deploy, either...I get:

...
There were errors during this build, re-run with `middleman build --verbose` to see the full exception.

@JonRowe, can you take a look?

@soulcutter
Copy link
Member

Odd, it built for me, although I got several bourbon sass warnings

Bradley Schaefer

On Oct 3, 2015, at 4:11 PM, Myron Marston notifications@github.com wrote:

Thanks! I can't deploy, either...I get:

...
There were errors during this build, re-run with middleman build --verbose to see the full exception.
@JonRowe, can you take a look?


Reply to this email directly or view it on GitHub.

@JonRowe
Copy link
Member

JonRowe commented Oct 4, 2015

Deployed

@JonRowe
Copy link
Member

JonRowe commented Oct 4, 2015

It builds fine for me so it might be a gem version issue?

@JonRowe
Copy link
Member

JonRowe commented Oct 4, 2015

My gems for comparison https://gist.github.com/JonRowe/4a9bffd7e0bcbfa920ab

@myronmarston
Copy link
Member Author

Somehow the deploy got borked, @JonRowe. Notice the lack of styles at http://rspec.info/documentation/3.3/rspec-core/.

Want to try re-deploying? I tried but I'm still getting the error message.

@JonRowe
Copy link
Member

JonRowe commented Oct 11, 2015

Working on it

@JonRowe
Copy link
Member

JonRowe commented Oct 14, 2015

I'm not sure when this was last working, previous commits on master seem to have the same issue, the fix I worked up before doesn't seem to be the one we used in the end (as the plugin hasn't been used to generate the doc files so the css is in the wrong place) I have a solution involving using middleman's proxy directive but at the moment it causes my middleman build to fail for the "latest" files

@myronmarston
Copy link
Member Author

Previously we had seen it fail on some deploys but then work on a redeploy. Is that no longer the case?

@JonRowe
Copy link
Member

JonRowe commented Oct 14, 2015

Doesn't seem to be

@JonRowe
Copy link
Member

JonRowe commented Oct 14, 2015

Any idea how we fixed this in the end? I can't find evidence of anything but the plugin I wrote, but that doesn't seem to have been used...

@myronmarston
Copy link
Member Author

Nope, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants