Skip to content

Updated gems #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2015
Merged

Updated gems #68

merged 1 commit into from
Apr 26, 2015

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Apr 25, 2015

I had to do this to deploy the site on Ruby 2.2.2, everything looks the same to me but we need to address some deprecations in future.

@myronmarston
Copy link
Member

I had to do this to deploy the site on Ruby 2.2.2

Why? Do you no longer have 2.1 (or whatever you used previously) installed

everything looks the same to me but we need to address some deprecations in future.

What are the deprecations? Can you paste them in.

@JonRowe
Copy link
Member Author

JonRowe commented Apr 26, 2015

Why? Do you no longer have 2.1 (or whatever you used previously) installed

I tend to update and run the latest ruby whenever possible, the 2.1 / 2.2 difference requires you to update some gems which fail to install on 2.2.

Do you have an objection to upgrading gems? I find it's good to do this often so you're not caught out with big changes!

What are the deprecations? Can you paste them in.

They're from CSS mixins, need to investigate what we need to do to replace the deprecated mixins

WARNING: The button mixin is deprecated and will be removed in the next major version release
         on line 64 of /Users/jon/.rvm/gems/ruby-2.2.2@RSpec-www/gems/bourbon-4.2.2/app/assets/stylesheets/_bourbon-deprecated-upcoming.scss, in `button'
         from line 2 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/extends/_button.scss
         from line 1 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/extends/_base.scss
         from line 10 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_bitters.scss
         from line 5 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/application.css.scss

WARNING: The box-sizing mixin is deprecated and will be removed in the next major version release. This property can now be used un-prefixed.
         on line 410 of /Users/jon/.rvm/gems/ruby-2.2.2@RSpec-www/gems/bourbon-4.2.2/app/assets/stylesheets/_bourbon-deprecated-upcoming.scss, in `box-sizing'
         from line 40 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_forms.scss
         from line 13 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_bitters.scss
         from line 5 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/application.css.scss

WARNING: The button mixin is deprecated and will be removed in the next major version release
         on line 64 of /Users/jon/.rvm/gems/ruby-2.2.2@RSpec-www/gems/bourbon-4.2.2/app/assets/stylesheets/_bourbon-deprecated-upcoming.scss, in `button'
         from line 2 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/extends/_button.scss
         from line 1 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/extends/_base.scss
         from line 10 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_bitters.scss
         from line 5 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/application.css.scss
         from line 1 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/pages/index.css.scss

WARNING: The box-sizing mixin is deprecated and will be removed in the next major version release. This property can now be used un-prefixed.
         on line 410 of /Users/jon/.rvm/gems/ruby-2.2.2@RSpec-www/gems/bourbon-4.2.2/app/assets/stylesheets/_bourbon-deprecated-upcoming.scss, in `box-sizing'
         from line 40 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_forms.scss
         from line 13 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/bitters/_bitters.scss
         from line 5 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/application.css.scss
         from line 1 of /Users/jon/Code/Gems/rspec-website/source/stylesheets/pages/index.css.scss

@myronmarston
Copy link
Member

Do you have an objection to upgrading gems?

No problem whatsoever. Upgrading is a great idea. I just misread your "I had to do this" statement above to mean that you couldn't deploy w/o upgrading to ruby 2.2 and upgrading gems.

I find it's good to do this often so you're not caught out with big changes!

Yep, thanks for taking care of this.

myronmarston added a commit that referenced this pull request Apr 26, 2015
@myronmarston myronmarston merged commit a512ef0 into source Apr 26, 2015
@myronmarston myronmarston deleted the upgrade_gems branch April 26, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants