Skip to content

Add RSpec-dev to Contributing; RSpec-Support to repos #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2015
Merged

Add RSpec-dev to Contributing; RSpec-Support to repos #65

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddeb40d
Add copy and link to rspec-dev to Contributing
bf4 Feb 8, 2015
1b15e64
Add RSpec-Support to list of repos
bf4 Feb 8, 2015
8580eeb
Add RSpec-dev to list of repos
bf4 Feb 8, 2015
1fe7f26
Per soulcutter
bf4 Nov 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add copy and link to rspec-dev to Contributing
  • Loading branch information
@bf4
bf4 committed Nov 2, 2015
commit ddeb40d8d341ac6857f35936abfaf89c31e1e78a
6 changes: 6 additions & 0 deletions source/contributing.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@ section
p
| If you have an idea to improve RSpec or find a bug, you are encouraged
to file a pull request or issue with the appropriate repository on GitHub.
p
| See 
= link_to 'rspec-dev', 'https://github.com/rspec/rspec-dev'
|  for how to develop on and test RSpec, as well as any 
= link_to 'DEV-README.md', '(https://github.com/rspec/rspec-core/blob/master/DEV-README.md'
|  that may be in that repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to add  's to the tart of the lines, just add an actual space like used on _repos#16.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear you can run middleman server to preview how this looks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did. I looked at repos partial for how you handled the spacing and saw the nbsp. I haven't used slim so just did what looked like the most consistent thing. About to push up a fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's only necessary at the end because it trims spaces and there's no haml style <> processor option I've found.

= partial "repos"