-
-
Notifications
You must be signed in to change notification settings - Fork 41
Add initial draft of 3.8 blog post. #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
support the [XDG Base Directory | ||
Specification](https://specifications.freedesktop.org/basedir-spec/latest/), | ||
which defines a standard way for tools to locate the global personal | ||
options file. This gives users complete control over where this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double spacing typo here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old habit of mine. Fixed.
[RSpec 3.3](/blog/2015/06/rspec-3-3-has-been-released/#core-bisect). | ||
This feature is useful when your test suite has an ordering | ||
dependency--that is, the suite only fails when the tests are run | ||
in a specific order. `--bisect` will repeatedly run smaller and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double spacing typo here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
### Expectations: Formatted output length is now configurable | ||
|
||
TODO (Sam/Benoit): write this up since you authored this feature | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Expectations: Failure message improvements
A big thank you to Tomohiro Hashidate and Nicktime who have improved our output
for a couple of failure cases, see the full change log for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem all that notable, to be honest. If it's not important enough to describe, we shouldn't mention it, I don't think. It's in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to highlight this as I feel documentation / usability tweaks are important, it was more of a "shout out" than "notable".
|
||
### Expectations: Formatted output length is now configurable | ||
|
||
TODO (Sam/Benoit): write this up since you authored this feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
When dealing with larger objects their string representations can become rather unwieldy and can clutter the console output. In RSpec 3.6 we started truncating these objects to prevent this issue but due to an oversight this was never made easily configurable. In 3.7 RSpec Expectations has a new configuration option allowing changing this value and also allows turning it off (by setting the limit to
nil
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've adapted this.
|
||
### Rails: ? | ||
|
||
TODO (Sam/Benoit/Jon): figure out what is notable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Rails: `have_http_status` matcher upgraded to support Rails 5.2
Since Rails 5.2 the `have_http_status` matcher has issued deprecation warnings due to a change in the name
of the various states. In RSpec 3.8 these warnings are removed.
### Rails: View specs `stub_template` performance improved.
Thanks to Simon Coffey for implementing caching for `stub_template` that prevents unnecessary recreation of
templates. This improves performance by reducing the amount of allocation and setup performed.
### Rails: `rails_helper.rb`
Thank you to Koichi ITO and Alessandro Rodi for improving our generated `rails_helper.rb` with improved messages when migrations are pending, and bringing us in line with Rails standards.
### Rails: Scafold generator
Thanks to Laura Paakkinen, our scaffold generator now correctly respects longer namespaces for generating controllers / routes, e.g. `api/v1/posts` now generates `Api::V1::Posts`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've added these, except for the last one. It's not clear what qualifies as a "longer namespace." Is it one over 10 characters? 20? 30? And also it doesn't seem that notable--it's just a bug fix, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its any multi part namespace over 2, I'm on the fence about it but similar to the other questionable one, it was more about highlighting contributor effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor effort has never been the basis on whether or not we highlight something as notable in our release blog post. It's about the effect the change has for users of RSpec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, how do you feel, given that our contributor count is quite low at the moment, about simply listing everyone who helped on this release at the end of the blog post? A "And thanks to who helped with this release".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All contributors will be listed in "Stats" section (example). And they're also listed in the changelog for their individual contributions. We don't need to list all the contributors 3 times in the same blog post.
### Rails: `have_http_status` matcher upgraded to support Rails 5.2 | ||
|
||
A change in Rails 5.2 caused RSpec's `have_http_status` matcher to issue deprecation | ||
warnings. In RSpec 3.9, these warnings have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
- 3.9 -> 3.8 - Rename file to reflect actual release date.
Let's ship 3.8 ASAP.
@benoittgt @samphippen @JonRowe I could use some help with a couple sections -- specifically, the notable rspec-rails changes (I have no idea) and the "Formatted output length" change in expectations (that Sam and Benoit did).
Ideally, I'd like to release 3.8 at the end of this week or beginning of next.