Support mobile devices #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
May 8, 2017
| == yield_content(:head) | ||
|
|
||
| title= current_page.data.title | ||
|
|
||
| == stylesheet_link_tag 'application', 'normalize' |
There was a problem hiding this comment.
Are we sure we import application in every page partial? I'm not even sure we have a page partial for every page :/
There was a problem hiding this comment.
I've confirmed that all pages are properly displayed with this. Actually I want to refactor all the stylesheets but doing so is out of scope of this PR.
There was a problem hiding this comment.
@yujinakayama ok I trust you, merge and deploy at your lesuire
|
Any reason not to merge this? I trust @yujinakayama :). |
|
My concern has yet to be addressed, if @yujinakayama says we do in fact reimport it everywhere I'm okay with it, otherwise I'd like that addressed before merge. |
yujinakayama
force-pushed
the
support-mobile-devices
branch
2 times, most recently
from
aa370ae to
8ef2a82
Compare
bundle update json eventmachine
application.css was loaded by browser while it was also combined in page specific CSS.
yujinakayama
force-pushed
the
support-mobile-devices
branch
from
8ef2a82 to
83e5fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're still some skewed layouts on mobile devices but it's better than the current desktop-only support.
Before
After