Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Define module we can use to safely rescue most exceptions.#237

Merged
xaviershay merged 1 commit intomasterfrom
non-pass-through-exceptions
Aug 31, 2015
Merged

Define module we can use to safely rescue most exceptions.#237
xaviershay merged 1 commit intomasterfrom
non-pass-through-exceptions

Conversation

@myronmarston
Copy link
Copy Markdown
Member

No description provided.

@myronmarston
Copy link
Copy Markdown
Member Author

Anyone want to review this? It supports rspec/rspec-expectations#844 and rspec/rspec-core#2063.

@myronmarston
Copy link
Copy Markdown
Member Author

I'd love to get this merged before leaving on my 3-week vacation tomorrow. Anyone want to review this, @rspec/rspec ?

Bear in mind that the failures from the rspec-core and rspec-expectations PRs are due to a bug in our build scripts -- see rspec/rspec-dev#137.

@xaviershay
Copy link
Copy Markdown
Member

looking...

Comment thread lib/rspec/support.rb
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, great name and comment

@xaviershay
Copy link
Copy Markdown
Member

LGTM

xaviershay added a commit that referenced this pull request Aug 31, 2015
Define module we can use to safely rescue most exceptions.
@xaviershay xaviershay merged commit 08fe8c1 into master Aug 31, 2015
@myronmarston
Copy link
Copy Markdown
Member Author

Thanks, @xaviershay.

@myronmarston myronmarston deleted the non-pass-through-exceptions branch August 31, 2015 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants