This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Allow a caller to pass a skip_frames arg to first_non_rspec_line.
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can speed things up in some situations.
|
LGTM, nice comment |
JonRowe
added a commit
that referenced
this pull request
Jan 13, 2015
Allow a caller to pass a skip_frames arg to `first_non_rspec_line`.
|
👍 |
myronmarston
added a commit
to rspec/rspec-core
that referenced
this pull request
Jan 14, 2015
The call to `RSpec::CallerFilter.first_non_rspec_line` took most of the time. I originally planned to leverage rspec/rspec-support#155 but realized we could avoid calling that entirely by re-using the location from the group’s metadata. I re-ran all the benchmarks and updated them. They look much, much better.
myronmarston
added a commit
to rspec/rspec-core
that referenced
this pull request
Jan 15, 2015
The call to `RSpec::CallerFilter.first_non_rspec_line` took most of the time. I originally planned to leverage rspec/rspec-support#155 but realized we could avoid calling that entirely by re-using the location from the group’s metadata. I re-ran all the benchmarks and updated them. They look much, much better.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
The call to `RSpec::CallerFilter.first_non_rspec_line` took most of the time. I originally planned to leverage rspec/rspec-support#155 but realized we could avoid calling that entirely by re-using the location from the group’s metadata. I re-ran all the benchmarks and updated them. They look much, much better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can speed things up in some situations. I'm planning to use this as part of my on-going perf improvements for rspec/rspec-core#1749.
/cc @xaviershay @JonRowe