-
-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
14 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -196,7 +196,20 @@ def object.some_method | |
end | ||
|
||
if defined?(Fiber) && RUBY_VERSION.to_f >= 2.0 | ||
it "shares data across fibres" do | ||
broken_on_jruby = | ||
if RSpec::Support::Ruby.jruby? | ||
"As Fibre.new creates a new thread on JRuby this is currently " \ | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
JonRowe
Author
Member
|
||
"broken. There are alternative implementations that do work but " \ | ||
"they cause issues for mocks, so given this is a minor edge case " \ | ||
"and thread data is already broken, its acceptable. Pending " \ | ||
"because future JRuby may fix this. see: "\ | ||
"https://github.com/jruby/jruby/issues/1806 and " \ | ||
"https://github.com/rspec/rspec-support/pull/610" | ||
else | ||
false | ||
end | ||
|
||
it "shares data across fibres", :pending => broken_on_jruby do | ||
RSpec::Support.thread_local_data[:__for_test] = :oh_hai | ||
|
||
Fiber.new do | ||
|
Fiber?