Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warning in mailer preview path check #2794

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Silence warning in mailer preview path check #2794

merged 3 commits into from
Sep 4, 2024

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Sep 4, 2024

No description provided.

@JonRowe JonRowe force-pushed the fix-ruby-3-3-5 branch 3 times, most recently from 94445e6 to 12cf79c Compare September 4, 2024 15:27
@davidrunger
Copy link
Contributor

@JonRowe : A possible alternative is here: #2796 , although I'm not sure whether you have already considered that approach and believe your approach here to be superior, and I'm also not 100% sure that will actually get all of the specs passing (although I think it will).

This was referenced Sep 4, 2024
Merged
Closed
@JonRowe JonRowe marked this pull request as ready for review September 4, 2024 16:50
@JonRowe JonRowe merged commit 40069a2 into main Sep 4, 2024
17 checks passed
@JonRowe JonRowe deleted the fix-ruby-3-3-5 branch September 4, 2024 17:28
JonRowe added a commit that referenced this pull request Sep 4, 2024
@JonRowe
Merge pull request #2794 from rspec/fix-ruby-3-3-5
bc6dfc7 
Silence warning in mailer preview path check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonRowe @davidrunger