Reword mailer specs doc strings for ensuring deliveries are cleared #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
changed the title
benoittgt
approved these changes
Mar 21, 2020
|
Thanks. Much better. |
pirj
reviewed
Mar 21, 2020
| @@ -257,8 +257,8 @@ def self.application; end | |||
| expect(group.new).to be_a(RSpec::Rails::MailerExampleGroup) | |||
| end | |||
|
|
|||
| describe 'leans test mailbox after each example' do | |||
| let(:base_mailer) do | |||
| describe 'clears ActionMailer::Base::Deliveries after each example' do | |||
There was a problem hiding this comment.
Sorry for the late appearance. Do you think it makes sense to add order: :defined here?
There was a problem hiding this comment.
Their is no need. You need at least two example, order does not mater. :)
There was a problem hiding this comment.
Yep they are order independant, they just need different emails.
JonRowe
added a commit
that referenced
this pull request
Mar 24, 2020
Reword mailer specs doc strings for ensuring deliveries are cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.