Fix be_routable
description -- Renames BeRoutableMatcher to BeRoutable
#1307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, using
be_routable
in a one-liner......will output the following:
BaseMatcher#description
turnsBeRoutableMatcher
into "be routable matcher".Solution
The solution implemented here is to rename
BeRoutableMatcher
toBeRoutable
in order to rely onBaseMatcher#description
to correctly return the following description:This looks like the precedence in other matchers like
BeValid
.Alternate Solution
Alternatively,
#description
could be overridden inBeRoutableMatcher
:I'd be happy to change PR if that's preferred 😸