Omit redandunt execution with rspec --bisect #3100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makicamel
force-pushed
the
omit-redandunt-execution-with-rspec-bisect
branch
from
ef995c7
to
e2e1a1f
Compare
Since bisect is a command that finds minimum repro that fails depending on the order, examples after the last failure example doesn't need to be executed.
|
I'm sorry, I made a PR without realizing that the cucumber tests failed. I'll fix it 🙏 |
makicamel
force-pushed
the
omit-redandunt-execution-with-rspec-bisect
branch
from
e2e1a1f
to
9660048
Compare
makicamel
commented
Jul 12, 2024
| When I run `rspec --seed 1234` | ||
| Then the output should contain "10 examples, 1 failure" | ||
| When I run `rspec --seed 1234 --bisect` | ||
| When I run `rspec --seed 9876` |
There was a problem hiding this comment.
I changed seed number because when seed is 1234 calculator_1_spec is executed before calculator_20_spec
| @@ -28,8 +28,8 @@ Feature: Bisect | |||
| end | |||
| end | |||
| """ | |||
| And files "spec/calculator_2_spec.rb" through "spec/calculator_9_spec.rb" with an unrelated passing spec in each file | |||
| And a file named "spec/calculator_10_spec.rb" with: | |||
| And files "spec/calculator_2_spec.rb" through "spec/calculator_19_spec.rb" with an unrelated passing spec in each file | |||
There was a problem hiding this comment.
I increased the number of files to 20, because with 10 the bisect would complete before abort with Ctr-C.
|
I think this behaviour should be at best opt-in because even if we have encountered all the original failures, there might be more failures that occur that would technically make a run a different set of results and thus be an unstable bisect... |
|
Thank you, I'll try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bisect is a command that finds minimum repro that fails depending on the order, examples after the last failure example doesn't need to be executed.