docs: emphasize gem backtrace exclusion patterns

[e2]

Give better example for filtering with multiple gems

[e2]

should be "patterns for the"

[myronmarston]

Actually, should be "patterns to the", I think. Besides assigning to backtrace_exclusion_patterns, you can also append to it, and that's probably worth calling out here.

[myronmarston]

Nice improvement, @e2, I left a few comments. Ignore the build failure for now; it's due to a new aruba release that broke us.

[e2]

I didn't wrap in RSpec.configure do (...) end because I added the patterns example code. Besides, the examples below use RSpec.configure blocks - which clear any confusion.

[myronmarston]

Thanks, @e2. One other thing I forgot to mention before: on relish, hand-wrapped markdown doesn't render well because it puts line breaks everywhere you put one rather than treating it as a free-flowing paragraph. I used to push to a relish staging environment (https://relishapp.com/rspec-staging) so that I could see how it renders and adjust my line breaks accordingly until I realized it was simpler just to not put any line breaks in the middle of a paragraph, letting relish's markdown render put them at the appropriate places. So now I find it easier/better to write relish narrative paragraphs as one long unbroken line each. Do you mind changing your paragraphs to that?

With that in place, this'll be good to merge. Thanks!

[myronmarston]

Regarding the failed build...I just merged #1848 which fixes it, so do you mind rebasing against master so that the builds here include that? Then we should be able to see a green build here which is always nice.

[e2]

I'm not sure if I understood correctly about the newlines - let me know if I didn't (I'm not sure). I tried not to change the original at first (I had newlines pretty much like in the original), so I don't see how I "introduced" any problems.

[myronmarston]

I'm not sure if I understood correctly about the newlines - let me know if I didn't (I'm not sure)

That's not what I meant. Maybe an example will make what I meant clearer (sorry that my description wasn't clear!). Check out the long unwrapped lines that were added in this PR, particularly the linked line and discussion:

https://github.com/rspec/rspec-core/pull/1842/files#diff-55a2a0f3cabfec543152971929f30a32R15

[e2]

(facepalm) - I get it now.

Fixed.

Let me know if there's anything else.

[myronmarston]

👍 Will merge when green. Thanks!

[e2]

Thanks as well! I'll start with a PR next time.