This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove reference to loading rails in spec helper documentation. #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't updated rspec-rails to not do this yet, and we should be consistent. Added an extra sentence suggesting the direction we are moving. Related: writing that sentence without using "require" three times was a difficult exercise.
myronmarston
added a commit
that referenced
this pull request
Apr 20, 2014
Remove reference to loading rails in spec helper documentation.
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't updated rspec-rails to not do this yet, and we should be
consistent. Added an extra sentence suggesting the direction we are
moving.
Related: writing that sentence without using "require" three times was a
difficult exercise.
We can revert this (or at least add back the rails suggestion) once rspec/rspec-rails#990 is addressed.
@myronmarston @alindeman