WebSocket Transport #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <shadowgun@i.ua> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
dnadoba
requested review from
ciychodianda,
gabeb-intu,
nkristek,
OlegDokuka and
Samer-Abdulaziz
as code owners
nkristek
reviewed
Apr 6, 2021
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Signed-off-by: David Nadoba <dnadoba@gmail.com> Conflicts: Sources/RSocketCore/Channel Handler/SetupWriter.swift
Signed-off-by: David Nadoba <dnadoba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add basic WebSocket transport support
Motivation:
make Twitter and Timer examples work
Modifications:
Sec-WebSocket-Keyas defined in RFC6455ByteBufferByteBufferas binary WebSocket frameResult:
Twitter and Timer examples do work now
Discussion
WebSocket text frame
The current implementation just ignores text frames. How do other implementations handle text frames?
WebSocket Fragmentation
The current implementation does not support WebSocket fragmentation. I don't know if we need this because RSocket already supports fragmentation but I could imagine that an intermediate WebSocket Proxy might fragment frames by accident so it might be worth to add it just to be sure.
WebSocket close frame
The current implementation does not handle WebSocket close frames. We definitely need to tackle this in the future.