Skip to content

Deprecate nodejs transport in favor of ktor #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Deprecate nodejs transport in favor of ktor #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rsocket-transports/nodejs-tcp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2015-2024 the original author or authors.
* Copyright 2015-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -20,7 +20,7 @@ plugins {
id("rsocketbuild.multiplatform-library")
}

description = "rsocket-kotlin NodeJS TCP client/server transport implementation"
description = "[DEPRECATED] rsocket-kotlin NodeJS TCP client/server transport implementation"

kotlin {
jsTarget(supportsBrowser = false)
Expand Down
74 changes: 0 additions & 74 deletions ...-tcp/src/jsMain/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/NodejsTcpClientTransport.kt
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions ...odejs-tcp/src/jsMain/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/NodejsTcpConnection.kt
View file
Open in desktop

This file was deleted.

108 changes: 0 additions & 108 deletions ...-tcp/src/jsMain/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/NodejsTcpServerTransport.kt
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...nodejs-tcp/src/jsMain/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/TcpClientTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2015-2024 the original author or authors.
* Copyright 2015-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,7 +23,7 @@ import kotlinx.coroutines.*
import kotlin.coroutines.*

@Suppress("DEPRECATION_ERROR")
@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of new Transport API, use NodejsTcpClientTransport")
@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of `rsocket-transport-ktor-tcp` with ktor 3.1")
public class TcpClientTransport(
private val port: Int,
private val hostname: String,
Expand Down
6 changes: 3 additions & 3 deletions ...nodejs-tcp/src/jsMain/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/TcpServerTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2015-2024 the original author or authors.
* Copyright 2015-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -22,7 +22,7 @@ import io.rsocket.kotlin.transport.nodejs.tcp.internal.*
import kotlinx.coroutines.*
import kotlin.coroutines.*

@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of new Transport API, use NodejsTcpServerInstance")
@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of `rsocket-transport-ktor-tcp` with ktor 3.1")
public class TcpServer internal constructor(
public val job: Job, private val server: Server
) {
Expand All @@ -32,7 +32,7 @@ public class TcpServer internal constructor(
}

@Suppress("DEPRECATION_ERROR")
@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of new Transport API, use NodejsTcpServerTransport")
@Deprecated(level = DeprecationLevel.ERROR, message = "Deprecated in favor of `rsocket-transport-ktor-tcp` with ktor 3.1")
public class TcpServerTransport(
private val port: Int, private val hostname: String,
) : ServerTransport<TcpServer> {
Expand Down
10 changes: 1 addition & 9 deletions ...s/nodejs-tcp/src/jsTest/kotlin/io/rsocket/kotlin/transport/nodejs/tcp/TcpTransportTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2015-2024 the original author or authors.
* Copyright 2015-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -35,11 +35,3 @@ class TcpTransportTest : TransportTest() {
server.close()
}
}

class NodejsTcpTransportTest : TransportTest() {
override suspend fun before() {
val port = PortProvider.next()
startServer(NodejsTcpServerTransport(testContext).target("127.0.0.1", port))
client = connectClient(NodejsTcpClientTransport(testContext).target("127.0.0.1", port))
}
}