Skip to content

сleanups of close/release inconsistency #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 23, 2021
Merged

сleanups of close/release inconsistency #182

merged 1 commit into from Aug 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2021

NOTE: Depends on #178

  • Metadata, PayloadBuilder and CompositeMetadataBuilder implements Closeable
  • remove Frame.release and Payload.release (use close instead)
  • use close instead of release everywhere
  • use sealed in composite and auth metadata

@ghost ghost marked this pull request as ready for review August 19, 2021 12:38
…eable

remove Frame.release and Payload.release (use close instead)
use close instead of release everywhere
use sealed in composite and auth metadata
@OlegDokuka OlegDokuka changed the title Cleanup of close/release inconsistency сleanups of close/release inconsistency Aug 23, 2021
@OlegDokuka OlegDokuka merged commit d83b2c7 into rsocket:master Aug 23, 2021
@ghost ghost mentioned this pull request Aug 23, 2021
@ghost ghost deleted the close-cleanup branch August 25, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant