Skip to content

Rework internals - preparation for fragmentation #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Aug 19, 2021
Merged

Rework internals - preparation for fragmentation #176

merged 3 commits into from Aug 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2021

  • improve setup payload handling to release it even if it not used, and allow to use it at client side both inside SetupFrame sending and inside acceptor
  • simplify usage of flows with RequestStrategy
  • rewrite streams to use one Map with FrameHandler instead of Map per Job, Limiter and Channel
    • FrameHandler is an abstraction over stream, which handles all kind of frames for specific frame + handles request life-cycle
    • in next PR it will also handle reassembling of frames
  • remove several hacks needed for K/N
  • change scopes used for requests/connection lifecycle - this will be improved for customization in next PR

@ghost ghost mentioned this pull request Jul 15, 2021
@yschimke
Copy link
Member

Won't progress on further reviews until #175 lands

@ghost ghost marked this pull request as ready for review July 21, 2021 09:50
@yschimke
Copy link
Member

I can't give a meaningful review of this, it's big and requires understanding of where you are heading. Tests are quite good, so LGTM.

@OlegDokuka OlegDokuka merged commit 5526b27 into rsocket:master Aug 19, 2021
@ghost ghost deleted the internals-rework branch August 19, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants