Switching FrameType flags back to bits #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n array when looking up flags Signed-off-by: Robert Roeser <rroeserr@gmail.com>
robertroeser
force-pushed
the
frameType
branch
from
3118fdd to
1fe4166
Compare
rdegnan
approved these changes
Nov 12, 2018
| @DisplayName( | ||
| "Rejecting setup by server causes requester RSocket disposal and RejectedSetupException") | ||
| @ParameterizedTest | ||
| @MethodSource(value = "transports") | ||
| @MethodSource(value = "transports")*/ |
There was a problem hiding this comment.
This test is failing due to reactor-netty bug fixed by reactor/reactor-netty#462 in Californium-RELEASE. Before update It can be worked around with (works in some environments only)test { environment "java.net.preferIPv4Stack", "true"} in rsocket-transport-netty buildfile
mostroverkhov
approved these changes
Nov 12, 2018
OlegDokuka
reviewed
Nov 12, 2018
| FrameType(int encodedType) { | ||
| this(encodedType, EnumSet.noneOf(Flags.class)); | ||
| this(encodedType, 0); |
There was a problem hiding this comment.
Suggested change
| this(encodedType, 0); | |
| this(encodedType, Flags.EMPTY); |
| IS_REQUEST_TYPE; | ||
|
|
||
| private static class Flags { | ||
| private static final int CAN_HAVE_DATA = 0b10000; |
There was a problem hiding this comment.
Suggested change
| private static final int CAN_HAVE_DATA = 0b10000; | |
| private static final int EMPTY = 0b00000; | |
| private static final int CAN_HAVE_DATA = 0b10000; |
Signed-off-by: Robert Roeser <rroeserr@gmail.com>
robertroeser
force-pushed
the
frameType
branch
from
2e9f5ca to
e6b3bb9
Compare
OlegDokuka
approved these changes
Nov 13, 2018
robertroeser
added a commit
to robertroeser/rsocket-java
that referenced
this pull request
Nov 20, 2018
* switching frame type flag back to bits so we don't have to traverse an array when looking up flags Signed-off-by: Robert Roeser <rroeserr@gmail.com> * jmh test Signed-off-by: Robert Roeser <rroeserr@gmail.com> * Added an EMPTY flag Signed-off-by: Robert Roeser <rroeserr@gmail.com> Signed-off-by: Robert Roeser <rroeserr@gmail.com>
robertroeser
added a commit
that referenced
this pull request
Nov 22, 2018
* reset to snapshots for next release * Switching FrameType flags back to bits (#548) * switching frame type flag back to bits so we don't have to traverse an array when looking up flags * jmh test * Added an EMPTY flag * changes from performance testing for Netty transport, and underlying RSocket core protocol * removing unused imports * switched to netty's IntObjectMap Signed-off-by: Robert Roeser <rroeserr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching FrameType flag back to bits. Current version uses an EnumSet which requires a contains method call. This method traverses and array, which requires you do this every time you created a Frame. This one does a bitmask and equals.