Simple Spring Queries #92
Conversation
| @@ -152,9 +152,14 @@ class Main : Runnable { | |||
| inputPublisher = LineInputPublishers(outputHandler) | |||
| } | |||
|
|
|||
| if (route != null) { | |||
| metadataFormat = "composite" | |||
There was a problem hiding this comment.
@linux-china What are firm assumptions we can make when route is selected?
There was a problem hiding this comment.
it's a nice to make Spring route simple. A question, I know some developers use cbor for data en/decoding with RSocket. Could you comment dataFormat assign(json by default now) when route is not null, and we can use route and cbor both. thanks.
if (route != null) {
metadataFormat = "composite"
// dataFormat = "json
}
There was a problem hiding this comment.
Should I remove binary as the default? Or check for it and then override to json?
I'd like to get it down to the minimal set of command line arguments to activate this.
There was a problem hiding this comment.
for binary, could we consider base64 text for cbor and other binary?
There was a problem hiding this comment.
binary as base64 text just for reference to implement CLI. we can consider this feature later. Now json is good for CLI to Spring RSocket, and Spring RSocketStrategies supports to config multi encoders.
There was a problem hiding this comment.
OK, I'm only setting when unset. Take a look.
example command line