Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-73: restrict typescript version #159

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

mortelli
Copy link
Contributor

This PR restricts the typescript version used in the project to prevent build errors.

For now, we're OK with using the older version to move forward. PP-75 is a follow-up issue to properly fix these build errors.

@mortelli mortelli added the bug Something isn't working label Aug 31, 2021
@mortelli mortelli requested a review from wilsoniovlabs August 31, 2021 00:29
@mortelli mortelli self-assigned this Aug 31, 2021
@mortelli
Copy link
Contributor Author

@antomor i cannot add you as a reviewer but please take a look when you can (make sure this matches the version you're using)

@antomor
Copy link
Collaborator

antomor commented Aug 31, 2021

LGTM!

Copy link
Contributor

@wilsoniovlabs wilsoniovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortelli mortelli merged commit 352c425 into develop Sep 1, 2021
@mortelli mortelli deleted the bugfix/PP-73/typescript-version branch September 1, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants