web3 in estimateRelayTransactionMaxPossibleGas reference changed #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JONAF2103
reviewed
Jun 15, 2021
mortelli
reviewed
Jun 16, 2021
There was a problem hiding this comment.
i agree on having this changed and also on @JONAF2103's suggestion.
i think we should also apply an analogous change in the relay provider:
rif-relay/src/relayclient/RelayProvider.ts
Line 307 in 4ee9289
raullaprida
force-pushed
the
contract_interactor_web3_ref_update
branch
from
41fb333 to
79f5e80
Compare
mortelli
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just adds a "this." in contractInteractor.estimateRelayTransactionMaxPossibleGas()