Adding Travis CI for building and testing the project. #33
Conversation
jgebal
force-pushed
the
feeature/travis-ci-builds
branch
2 times, most recently
from
7c59a3a to
a5483e8
Compare
|
@jgebal may you rebase this branch as it's in conflict after last merged PR. |
| - 2.2.4 | ||
| - 1.9.3 | ||
| - jruby-1.7.9 | ||
| - jruby-9.0.4.0 |
There was a problem hiding this comment.
Can we try with jruby-9.0.5.0 instead of 4?
There was a problem hiding this comment.
Sure, but I will not make it today. Need some good sleep after few too
short nights.
On 3 Mar 2016 17:40, "Yavor Nikolov" notifications@github.com wrote:
In .travis.yml
#33 (comment):
- chmod +x .travis/oracle/install.sh
- chmod +x .travis/setup_accounts.sh
+install:
- .travis/oracle/download.sh
- .travis/oracle/install.sh
- .travis/setup_accounts.sh
- bundle install
+language: ruby
+rvm:
- 2.3.0
- 2.2.4
- 1.9.3
- jruby-1.7.9
- jruby-9.0.4.0
Can we try with jruby-9.0.5.0 instead of 4?
—
Reply to this email directly or view it on GitHub
https://github.com/rsim/ruby-plsql-spec/pull/33/files#r54916836.
jgebal
force-pushed
the
feeature/travis-ci-builds
branch
2 times, most recently
from
189dc1d to
10f71f3
Compare
|
Rebased and changed to jruby 9.0.5.0 |
jgebal
force-pushed
the
feeature/travis-ci-builds
branch
2 times, most recently
from
63a30d3 to
6a70cf9
Compare
| - NLS_LANG=AMERICAN_AMERICA.AL32UTF8 | ||
| - ORACLE_BASE=/u01/app/oracle | ||
| - LD_LIBRARY_PATH=$ORACLE_HOME/lib | ||
| - PATH=$PATH:$ORACLE_HOME/jdbc/lib |
There was a problem hiding this comment.
Hmm, do we really want jdbc/lib in PATH? What is it for?
There was a problem hiding this comment.
Hmm, do we really want jdbc/lib in PATH? What is it for?
OK, I see now - it's to let JRuby find it.
|
Tests are passing on Travis-CI successfully. @jgebal may we just update the |
…n of the project.
jgebal
force-pushed
the
feeature/travis-ci-builds
branch
from
6a70cf9 to
74fd163
Compare
|
Updated to 2.2.1 Nailgun should speed up jruby tests. |
Thanks, @jgebal. What do you think about making it
Looking at the huge wait time until Travis-CI build is triggered (I guess this is because we need sudo), JRuby run is not the slowest part now. |
| # gem 'ruby-oci8', '~> 2.1.0' | ||
| gem 'ruby-oci8', :git => 'git://github.com/kubo/ruby-oci8.git', :platforms => :mri | ||
| platforms :ruby, :mswin, :mingw do | ||
| gem 'ruby-oci8', '~> 2.2.1' |
There was a problem hiding this comment.
What about gem 'ruby-oci8', '~> 2.1'?
|
@jgebal - I just added a few remarks: to be more up-to date with version numbers. May you review and update your branch to merge it? (I think there is no urge to delve in fine-tuning jruby performance here: we can handle it separately in future). |
I pushed a fork of this branch and PR so that I can merge it. I just added a few final touches as per my previous comments. |
No description provided.