MDL-39572: Fix sql_order_by_text() to use length argument correctly

rsendhil · Aug 15, 2013 · be8c6d7 · be8c6d7
1 parent be4bf53
commit be8c6d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/dml/mssql_native_moodle_database.php b/lib/dml/mssql_native_moodle_database.php
@@ -1220,7 +1220,7 @@ public function sql_length($fieldname) {
     }
 
     public function sql_order_by_text($fieldname, $numchars=32) {
-        return ' CONVERT(varchar, ' . $fieldname . ', ' . $numchars . ')';
+        return " CONVERT(varchar({$numchars}), {$fieldname})";
     }
 
    /**

diff --git a/lib/dml/sqlsrv_native_moodle_database.php b/lib/dml/sqlsrv_native_moodle_database.php
@@ -1281,7 +1281,7 @@ public function sql_length($fieldname) {
     }
 
     public function sql_order_by_text($fieldname, $numchars = 32) {
-        return ' CONVERT(varchar, '.$fieldname.', '.$numchars.')';
+        return " CONVERT(varchar({$numchars}), {$fieldname})";
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -1220,7 +1220,7 @@ public function sql_length($fieldname) { @@
         }
         public function sql_order_by_text($fieldname, $numchars=32) {
-            return ' CONVERT(varchar, ' . $fieldname . ', ' . $numchars . ')';
+            return " CONVERT(varchar({$numchars}), {$fieldname})";
         }
        /**
@@ Expand Down @@