Skip to content

remove jquery dependency #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willhoag
Copy link

@willhoag willhoag commented Oct 8, 2014

I think it's good to remove this dependancy because the module doesn't particularly need it.

I made the tests pass, but had to remove these two lines. Not sure if they are still necessary as elem isn't a jquery object anymore. Could use a double check on that. I just was getting an undefined error for both...

elem.remove();
angular.element(elem).scope().$destroy();

@philbarresi
Copy link

Not repo owner, but question -- karma.conf.js, line 20 you changed the location of jQuery instead of removing. I'm unfamiliar with karma -- does it need jQuery to run, or was the removal by accident?

@willhoag
Copy link
Author

Jquery isn't a dependency of Karma, but it can be useful for pulling objects from the dom for tests among other things. I updated the reference in the karma config because it was broken, but the angular-tooltip doesn't require it.

@philbarresi
Copy link

Ah, that makes sense. This repo needs a little love so I forked you! Thanks for explaining that 😄

@willhoag
Copy link
Author

:) Not a problem! Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants