Implements '*'(expand all) field selector. Closes: #147 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
previously approved these changes
Jan 10, 2019
Dragomir-Ivanov
force-pushed
the
master
branch
from
c6adab2 to
37872a5
Compare
Contributor
Author
|
@smyrman This is whole revamped version of the functionality. There is a lot to digest, so take your time with the review. |
Dragomir-Ivanov
force-pushed
the
master
branch
from
f901cce to
3321a3a
Compare
Fixes `schema.Array` behaviour with `schema.Reference`. Adds projection validation to items within `schema.Array`.
Dragomir-Ivanov
force-pushed
the
master
branch
from
3321a3a to
6c8a96c
Compare
Contributor
Author
|
It may be more easy checking out my repo, and review with: Because the patch on this PR, reverts part of my previous work on arrays of |
smyrman
reviewed
Jan 12, 2019
Collaborator
smyrman
left a comment
smyrman
left a comment
There was a problem hiding this comment.
Still looks good to me.
smyrman
reviewed
Jan 12, 2019
smyrman
reviewed
Jan 13, 2019
smyrman
reviewed
Jan 13, 2019
Dragomir-Ivanov
force-pushed
the
master
branch
from
3395ee4 to
7c3d20a
Compare
smyrman
previously approved these changes
Jan 14, 2019
…place holder for other async resource (Reference,Connection)
Dragomir-Ivanov
force-pushed
the
master
branch
from
710d028 to
bc68a53
Compare
smyrman
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.