Avoid large memory allocations when doing forEach in case netmask is large (e.g. /8) #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
requested changes
Sep 3, 2018
| @@ -1,29 +1,34 @@ | |||
| { | |||
| "author": "Olivier Poitrey <rs@dailymotion.com>", | |||
| "name": "netmask", | |||
| "name": "@dschenkelman/netmask", | |||
| "netmask", | ||
| "subnet", | ||
| "ipcalc" | ||
| ], |
| @@ -0,0 +1,125 @@ | |||
| { | |||
| long=ip2long(@first) | ||
| lastLong=ip2long(@last) | ||
| index=0 | ||
| while long<=lastLong |
|
Next time you can just force push on the same branch, it will update the PR. |
|
Yup I know :), thanks. I just have a different project pointing to that tag/code so I wanted to keep that until this module is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…