Add support for Safari 5.2 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Last rev 1.2.1 does exactly this. Did you miss mu commit? :) |
Contributor
Author
|
Hmm. Maybe I should have said Safari 5.2 for Mountain Lion. I assumed Check my version number against your last commit. On Feb 17, 2012, at 8:43 PM, Olivier Poitrey
|
Owner
|
Oups you're right, I'll merge it. Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply bumped the Max Version in the Info.plist to 8535.18.5. It seems to work fine. I also bumped up SafariTabSwitching to 1.2.2 for you. I'm not sure how you generate the package that you host on Heroku so I'll let you deal with that.
Hope I didn't miss anything.
Thanks for the great plugin!