Skip to content

Add posibility to colors node in cli image generation#35

Merged
rrwick merged 1 commit into
rrwick:developmentfrom
natir:master
Mar 18, 2017
Merged

Add posibility to colors node in cli image generation#35
rrwick merged 1 commit into
rrwick:developmentfrom
natir:master

Conversation

@natir

@natir natir commented Feb 5, 2017

Copy link
Copy Markdown

Hi,

All is in the title.

May be we can change the option name.

Thank for your work

@rrwick

rrwick commented Mar 17, 2017

Copy link
Copy Markdown
Owner

Do you mean choosing colours for specific nodes? It is currently possible to change colour defaults, so you could give all nodes the same colour with something like --colour uniform --unicolpos blue. But there isn't a way to give nodes custom colours based on their name. I'll keep that in mind as a future feature. Thanks!

@natir

natir commented Mar 17, 2017

Copy link
Copy Markdown
Author

Actually in GUI mode you can load a csv file to set the color of each node in your graph. This pull request just add possibility to make this in cli mode. It's more clear ?

@rrwick rrwick changed the base branch from master to development March 18, 2017 07:44
@rrwick rrwick merged commit bf1d2ae into rrwick:development Mar 18, 2017
@rrwick

rrwick commented Mar 18, 2017

Copy link
Copy Markdown
Owner

Ah yes, I was bit oblivious and thought this was an issue (I got to it via the GitHub notifications) and just realised that it's a pull request! Sorry for the confusion...

I've merged it into Bandage's development branch, not master. But when I make a new release, I'll bring the change into the master branch too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants