Fix an incorrected finish which halted playback prematurely #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ario was that there were events being rapidly added to the recording.
eoghanmurray
referenced
this pull request
Jul 2, 2021
…is finished (#445) plus: fix the problem that sometimes return value of getCurrentTime() is negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario was that there were events being rapidly added to the recording.
I could only recreate it happening in this setTimeout/mousemove code path, but can't see why it wouldn't also apply to the non setTimeout call to
finish();:Just wanted to check I'm missing something;
Should the approach instead be to restart the requestAnimationFrame timer after an addEvent on a finished replay?