Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record canvas mutations #296

Merged
merged 2 commits into from
Aug 22, 2020
Merged

record canvas mutations #296

merged 2 commits into from
Aug 22, 2020

Commits on Aug 22, 2020

  1. record canvas mutations 

    close #60, #261

This patch implements the canvas mutation observer.
It consists of both the record and the replay side changes.

In the record side, we add a `recordCanvas` flag to indicate
whether to record canvas elements and the flag defaults to false.
Different from our other observers, the canvas observer was
disabled by default. Because some applications with heavy canvas
usage may emit a lot of data as canvas changed, especially the
scenarios that use a lot of `drawImage` API.
So the behavior should be audited by users and only record canvas
when the flag was set to true.

In the replay side, we add a `UNSAFE_replayCanvas` flag to indicate
whether to replay canvas mutations.
Similar to the `recordCanvas` flag, `UNSAFE_replayCanvas` defaults
to false. But unlike the record canvas implementation is stable and
safe, the replay canvas implementation is UNSAFE.
It's unsafe because we need to add `allow-scripts` to the replay
sandbox, which may cause some unexpected script execution. Currently,
users should be aware of this implementation detail and enable this
feature carefully.
    @Yuyz0112
    Yuyz0112 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    8a94d20 View commit details
    Browse the repository at this point in the history

  2. update canvas integration test

    @Yuyz0112
    Yuyz0112 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    6edf8d4 View commit details
    Browse the repository at this point in the history