Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform npm scrips using cross-env #17

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

DvdGiessen
Copy link
Contributor

Builds and tests complete flawlessly on Window now (tested on Windows 10).

@Yuyz0112
Copy link
Member

Thanks a lot! But the rrweb-snapshot also has the same problem and I would like to:

  1. update rrweb-snapshot to use cross-env
  2. release a new version of rrweb-snapshot
  3. update rrweb-snapshot in rrweb and use cross-env in rrweb too

So we will only have one commit about this in the rrweb repo, would mind me update rrweb-snapshot later today or you also like to contribute this to rrweb-snapshot?

@Yuyz0112
Copy link
Member

@DvdGiessen The PR in rrweb-snapshot have been merged, and you can run npm update rrweb-snapshot to update a new version in this PR when you are free.

@TimoStaudinger
Copy link
Contributor

Gave it a try with the changes on my Windows machine, and it looks like it's working perfectly now! 👍

@DvdGiessen
Copy link
Contributor Author

Rebased on latest master, included new rrweb-snapshot version and re-ran tests successfully on Windows.

@Yuyz0112 Yuyz0112 merged commit e563dc1 into rrweb-io:master Dec 29, 2018
@Yuyz0112
Copy link
Member

Thanks!

lewgordon-amplitude pushed a commit to lewgordon-amplitude/rrweb that referenced this pull request Aug 1, 2024
…overclas

fix(rrweb): Fix some css issues with :hover and rewrite max-device-width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants