Full overhawl of video & audio playback to make it more complete#1432
Merged
Full overhawl of video & audio playback to make it more complete#1432
Conversation
🦋 Changeset detectedLatest commit: 4eb2bba The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
approved these changes
Apr 17, 2024
Contributor
eoghanmurray
left a comment
eoghanmurray
left a comment
There was a problem hiding this comment.
This is great work; I haven't had a chance to fully test this in production, but I believe it is better in trunk than out of it as it provides missing functionality.
This was referenced Apr 26, 2024
Closed
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
…ete (rrweb-io#1432)" This reverts commit 123a81e.
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
…eb-io#1432) * Add support for capturing media attributes in rrweb-snapshot * Add loop to mediaInteractionParam * Add support for loop in RRMediaElement * Add support for recording loop attribute on media elements * Update video playback and fix bugs * Update cross-origin iframe media attributes and player state
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
…eb-io#1432) * Add support for capturing media attributes in rrweb-snapshot * Add loop to mediaInteractionParam * Add support for loop in RRMediaElement * Add support for recording loop attribute on media elements * Update video playback and fix bugs * Update cross-origin iframe media attributes and player state
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 28, 2026
…lete (rrweb-io#1432)" This reverts commit c6bc3c7.
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 28, 2026
…lete (rrweb-io#1432)" (#264) This reverts commit c6bc3c7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for capturing media attributes such as playbackRate, muted, and loop in the rrweb-snapshot library. It also includes updates to the video playback and fixes many bugs related to pausing, playing, skipping, muting, and playbackRate on media elements in rrweb itself.